Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-http] fixes traceparent header generation #5376

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

chradek
Copy link
Contributor

@chradek chradek commented Oct 3, 2019

The changes are smaller than they look...formatting changes are included.

I noticed while working on the event-hubs tracing that the traceparent header should start with a version number (always '00' for now), and the traceFlags should always be 2 digits.

Updating the TracingPolicy to use the function in core-tracing which handles this correctly.

@chradek chradek requested a review from daviwil as a code owner October 3, 2019 20:08
@chradek chradek requested a review from xirzec October 3, 2019 20:08
Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chradek chradek merged commit 756d290 into Azure:master Oct 3, 2019
@chradek chradek deleted the traceparent-policy branch October 3, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants